h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-05 16:21:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

Fix prefix/suffix icase comparisons

Browse Source 
As reported on Gitter, running "echo İ" makes history autosuggestion
for "echo i" crash.  This is because history search correctly
returns the former, but string_prefixes_string_case_insensitive("i",
"İ") incorrectly returns false.  This is because the prefix check
is implemented by trimming the rhs to the length of the prefix and
checking if the result is equal to the prefix.  This is wrong because
the prefix computation should operate on the canonical lowercase
version, because that's what history search uses.
This commit is contained in:
Johannes Altmanninger
2025-12-27 08:06:41 +01:00
parent a8ded9cb0d
commit 30942e16dc
4 changed files with 75 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/checks/tmux-autosuggestion.fish
View File

@@ -45,3 +45,8 @@ isolated-tmux send-keys C-l 'echo ('
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt {{\d+}}> echo (echo)
isolated-tmux send-keys C-u 'echo İ___' Enter C-l 'echo i'
tmux-sleep
isolated-tmux capture-pane -p
# CHECK: prompt {{\d+}}> echo İ___