Disable job control inside command substitutions

This disables job control inside command substitutions. Prior to this
change, a cmdsub might get its own process group. This caused it to fail
to cancel loops properly. For example:

    while true ; echo (sleep 5) ; end

could not be control-C cancelled, because the signal would go to sleep,
and so the loop would continue on. The simplest way to fix this is to
match other shells and not use job control in cmdsubs.

Related is #1362
This commit is contained in:
ridiculousfish
2021-07-26 13:12:30 -07:00
committed by David Adam
parent d27f477ba6
commit 2ca66cff53
6 changed files with 43 additions and 3 deletions

View File

@@ -2,6 +2,21 @@
# This hangs on OpenBSD
#REQUIRES: test "$(uname)" != OpenBSD
# Command subs run in same pgroup as fish, even if job control is 'all'.
# Verify that they get the same pgroup across runs (presumably fish's).
status job-control full
set g1 ($helper print_pgrp)
for i in (seq 10)
if test $g1 -ne ($helper print_pgrp)
echo "Unexpected pgroup"
end
end
status job-control interactive
echo "Finished testing pgroups"
#CHECK: Finished testing pgroups
# Ensure that if child processes SIGINT, we exit our loops
# Test for #3780