From 245ee466cbf2409a689f720158ed62c17d644962 Mon Sep 17 00:00:00 2001
From: Mahmoud Al-Qudsi <mqudsi@neosmart.net>
Date: Sun, 23 Jun 2024 18:08:34 -0500
Subject: [PATCH] completions/magento: remove sed dependency

This runs in about half the time, too.
---
 share/completions/magento.fish | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/share/completions/magento.fish b/share/completions/magento.fish
index 2a8ce342f..e9767088a 100644
--- a/share/completions/magento.fish
+++ b/share/completions/magento.fish
@@ -15,10 +15,23 @@ end
 ###
 
 function __fish_print_magento_modules -d "Lists all Magento modules"
-    test -f app/etc/config.php; or return
-    command -q sed; or return
+    set -l config_path app/etc/config.php
+    test -f $config_path; or return
 
-    command sed -n '/modules.*\[/,/\]/p' app/etc/config.php | sed -E '1d;$d;s/^\s*|\s*=>.*$|"|\'//g'
+    set -l in_modules 0
+    cat $config_path | \
+        while read -l line
+             if test "$in_modules" -eq 0
+                 if string match -rq '[\'"]modules[\'"]\s*=>.*\[' -- $line
+                     set in_modules 1;
+                 end
+             else
+                 if string match -rq '^\s*]\s*,\s*$' -- $line
+                     break
+                 end
+                 string replace -rf '\s*[\'"](.*?)[\'"]\s*=>.*' '$1' -- $line
+             end
+        end
 end
 
 function __fish_print_magento_i18n_packing_modes -d "Shows all available packing modes"
@@ -448,7 +461,7 @@ __fish_magento_register_command_option i18n:pack -s d -l allow-duplicates -d 'Us
 __fish_magento_register_command_option i18n:uninstall -f -s b -l backup-code -d 'Take code and configuration files backup (excluding temporary files)'
 __fish_magento_register_command_option i18n:uninstall -f -a "(__fish_print_magento_languages)" -d 'Language package name'
 
-# 
+#
 # info:dependencies:show-framework
 #
 __fish_magento_register_command_option info:dependencies:show-framework -f -s o -l output -d 'Report filename (default: "framework-dependencies.csv")'
@@ -474,8 +487,8 @@ __fish_magento_register_command_option maintenance:allow-ips -l none -d 'Clear a
 __fish_magento_register_command_option maintenance:disable -l ip -d "Allowed IP addresses (use 'none' to clear list)"
 
 #
-# maintenance:enable  
-# 
+# maintenance:enable
+#
 __fish_magento_register_command_option maintenance:enable -l ip -d "Allowed IP addresses (use 'none' to clear list)"
 
 #
@@ -488,7 +501,7 @@ __fish_magento_register_command_option module:disable -s c -l clear-static-conte
 
 #
 # module:enable
-# 
+#
 __fish_magento_register_command_option module:enable -f -a "(__fish_print_magento_modules)" -d "Module name"
 __fish_magento_register_command_option module:enable -f -s f -l force -d "Bypass dependencies check"
 __fish_magento_register_command_option module:enable -f -l all -d "Enable all modules"