From 1d36b04ea687b8441b63c31a9c2192a8a282d50e Mon Sep 17 00:00:00 2001 From: Daniel Rainer Date: Tue, 7 Oct 2025 02:40:21 +0200 Subject: [PATCH] check.sh: export gettext extraction file variable Some versions of `/bin/sh`, e.g. the one on FreeBSD, do not propagate variables set on a command through shell functions. This results in `FISH_GETTEXT_EXTRACTION_FILE` being set in the `cargo` function, but not for the actual `cargo` process spawned from the function, which breaks our localization scripts and tests. Exporting the variable prevents that. Fixes #11896 Closes #11899 --- build_tools/check.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build_tools/check.sh b/build_tools/check.sh index a25854230..ec8bf1226 100755 --- a/build_tools/check.sh +++ b/build_tools/check.sh @@ -49,7 +49,10 @@ if [ -n "$FISH_TEST_MAX_CONCURRENCY" ]; then fi template_file=$(mktemp) -FISH_GETTEXT_EXTRACTION_FILE=$template_file cargo build --workspace --all-targets --features=gettext-extract +( + export FISH_GETTEXT_EXTRACTION_FILE="$template_file" + cargo build --workspace --all-targets --features=gettext-extract +) if $lint; then PATH="$build_dir:$PATH" "$workspace_root/build_tools/style.fish" --all --check for features in "" --no-default-features; do