From 1c5b1ff5c239f68bfc4f9c3a9f824cfcac32abd6 Mon Sep 17 00:00:00 2001 From: ridiculousfish Date: Mon, 2 Mar 2020 14:00:20 -0800 Subject: [PATCH] Correct a race condition in pipeline-pgroup test This test launches two background processes and is sensitive to interleaving of output. Fix it so that newlines are not output by the background process. Hopefully this fixes the flakiness of this test. --- tests/checks/pipeline-pgroup.fish | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/checks/pipeline-pgroup.fish b/tests/checks/pipeline-pgroup.fish index aa86154c0..90dcdd752 100644 --- a/tests/checks/pipeline-pgroup.fish +++ b/tests/checks/pipeline-pgroup.fish @@ -43,7 +43,8 @@ or echo "Pgroups disagreed. Found $a0 $a1 $a2, and $b0 $b1 $b2" status job-control full $fth print_pgrp | begin tr \n ' ' - $fth print_pgrp & + $fth print_pgrp | tr \n ' ' & end & wait +echo # CHECK: {{(\d+) (?!\1)\d+}}