From 16d2f4faff4d06c26a162c50fb47fc2f1f0f73e0 Mon Sep 17 00:00:00 2001 From: Mahmoud Al-Qudsi Date: Sat, 29 Jul 2017 13:13:07 -0500 Subject: [PATCH] Added important comment about blocked_pid --- src/exec.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/exec.cpp b/src/exec.cpp index 97669ba6f..1251e5ed0 100644 --- a/src/exec.cpp +++ b/src/exec.cpp @@ -496,6 +496,8 @@ void exec_job(parser_t &parser, job_t *j) { // We are careful to set these to -1 when closed, so if we exit the loop abruptly, we can still // close them. bool pgrp_set = false; + //this is static since processes can block on input/output across jobs + //the main exec_job loop is only ever run in a single thread, so this is OK static pid_t blocked_pid = -1; int pipe_current_read = -1, pipe_current_write = -1, pipe_next_read = -1; for (std::unique_ptr &unique_p : j->processes) {