h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-09 12:11:20 -03:00
Code Issues Packages Projects Releases Wiki Activity

string: accept --char alias for pad and shorten

Browse Source 
Closes #12460
This commit is contained in:
Aditya Giri
2026-02-17 20:32:08 +05:30
committed by Johannes Altmanninger
parent 1b0fa8f804
commit 149fec8f02
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/builtins/string/pad.rs
View File

@@ -23,7 +23,8 @@ fn default() -> Self {
impl StringSubCommand<'_> for Pad {
const LONG_OPTIONS: &'static [WOption<'static>] = &[
// FIXME docs say `--char`, there was no long_opt with `--char` in C++
// Support both spellings: docs use --char, older fish accepted --chars.
wopt(L!("char"), RequiredArgument, 'c'),
wopt(L!("chars"), RequiredArgument, 'c'),
wopt(L!("right"), NoArgument, 'r'),
wopt(L!("center"), NoArgument, 'C'),

3
src/builtins/string/shorten.rs
View File

@@ -25,7 +25,8 @@ fn default() -> Self {
impl<'args> StringSubCommand<'args> for Shorten<'args> {
const LONG_OPTIONS: &'static [WOption<'static>] = &[
// FIXME: documentation says it's --char
// Support both spellings: docs use --char, older fish accepted --chars.
wopt(L!("char"), RequiredArgument, 'c'),
wopt(L!("chars"), RequiredArgument, 'c'),
wopt(L!("max"), RequiredArgument, 'm'),
wopt(L!("no-newline"), NoArgument, 'N'),

4
tests/checks/string.fish
View File

@@ -47,7 +47,7 @@ string pad foo
string pad -C foo
# CHECK: foo
string pad -r -w 7 --chars - foo
string pad -r -w 7 --char - foo
# CHECK: foo----
string pad -r -w 7 --chars - --center foo
# CHECK: --foo--
@@ -1003,7 +1003,7 @@ string shorten --max 4 -c /// foobar
string shorten --max 4 -c /// foobarnana
# CHECK: f///
string shorten --max 2 --chars "" foo
string shorten --max 2 --char "" foo
# CHECK: fo
string shorten foo foobar