From 141dcde498a3ef65608a0560078e0db93fafe6b3 Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Sun, 9 Apr 2023 14:09:53 +0200 Subject: [PATCH] signal.rs: crash a bit earlier when signal number is negative The conversion to usize is used for array accesses, so negative values would cause crashes either way. Let's do it earlier so we can get rid of the suspect C-style cast. --- fish-rust/src/signal.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fish-rust/src/signal.rs b/fish-rust/src/signal.rs index 365ac6de9..fd8607336 100644 --- a/fish-rust/src/signal.rs +++ b/fish-rust/src/signal.rs @@ -323,7 +323,7 @@ fn from(value: Signal) -> Self { impl From for usize { fn from(value: Signal) -> Self { - value.code() as usize + usize::try_from(value.code()).unwrap() } }