From 121d61cf31c237aa04533ddc543c82be7511daad Mon Sep 17 00:00:00 2001 From: Fabian Homborg Date: Fri, 26 Oct 2018 10:52:02 +0200 Subject: [PATCH] Revert "help: Use variable-as-command instead of eval" We do a bunch of escaping before to make `eval` work, and that needs to be removed as well or fragment-urls don't work. This reverts commit e9568069a76d7bb0694ef85f7fcf8e6621efdd9b. --- share/functions/help.fish | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/share/functions/help.fish b/share/functions/help.fish index 990b6ba87..e42ad81b7 100644 --- a/share/functions/help.fish +++ b/share/functions/help.fish @@ -165,14 +165,14 @@ function help --description 'Show help for the fish shell' case '*' printf (_ 'help: Help is being displayed in %s.\n') $fish_browser[1] end - $fish_browser $page_url & + eval "$fish_browser $page_url &" else # Work around lynx bug where
always has the same formatting as links (unreadable) # by using a custom style sheet. See https://github.com/fish-shell/fish-shell/issues/4170 set -l local_file 0 - if $fish_browser --version 2>/dev/null | string match -qr Lynx + if eval $fish_browser --version 2>/dev/null | string match -qr Lynx set fish_browser $fish_browser -lss={$__fish_data_dir}/lynx.lss end - $fish_browser $page_url + eval $fish_browser $page_url end end