h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-15 01:01:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

Correct the use of the constructed pointer in job lineage

Browse Source 
This was always being set to a different pointer. Ensure the root job
shares its constructed pointer with its children.
This commit is contained in:
ridiculousfish
2019-12-10 18:32:56 -08:00
parent 1e15aa4c4a
commit 0b1af1ace4
3 changed files with 26 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/exec.cpp
View File

@@ -313,7 +313,7 @@ void internal_exec(env_stack_t &vars, job_t *j, const io_chain_t &all_ios) {
// launch_process _never_ returns.
launch_process_nofork(vars, j->processes.front().get());
} else {
j->mut_flags().constructed = true;
j->mark_constructed();
j->processes.front()->completed = true;
return;
}
@@ -1225,7 +1225,7 @@ bool exec_job(parser_t &parser, shared_ptr<job_t> j) {
FLOGF(exec_job_exec, L"Executed job %d from command '%ls' with pgrp %d", j->job_id,
j->command_wcstr(), j->pgid);
j->mut_flags().constructed = true;
j->mark_constructed();
if (!j->is_foreground()) {
parser.vars().set_one(L"last_pid", ENV_GLOBAL, to_string(j->pgid));
}