From 05f52924c170fabd9e228a5f8a799d417085fd5d Mon Sep 17 00:00:00 2001 From: Mahmoud Al-Qudsi Date: Sat, 13 Apr 2019 17:07:58 -0500 Subject: [PATCH] Fix bad tests These tests used raw, unescaped parentheses to perform `test` logical grouping, but the test failures weren't caught because the parser evaluation errors were not being propagated (fixed in bdbd173e). --- src/fish_tests.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fish_tests.cpp b/src/fish_tests.cpp index dfee85398..136a50680 100644 --- a/src/fish_tests.cpp +++ b/src/fish_tests.cpp @@ -2330,8 +2330,8 @@ static void test_test() { // it would be false. do_test(run_test_test(0, L"0 = 0 -o 0 = 1 -a 0 = 2")); do_test(run_test_test(0, L"-n 5 -o 0 = 1 -a 0 = 2")); - do_test(run_test_test(1, L"( 0 = 0 -o 0 = 1 ) -a 0 = 2")); - do_test(run_test_test(0, L"0 = 0 -o ( 0 = 1 -a 0 = 2 )")); + do_test(run_test_test(1, L"\\( 0 = 0 -o 0 = 1 \\) -a 0 = 2")); + do_test(run_test_test(0, L"0 = 0 -o \\( 0 = 1 -a 0 = 2 \\)")); // A few lame tests for permissions; these need to be a lot more complete. do_test(run_test_test(0, L"-e /bin/ls"));